[CI] Add checkmark emojis for passing builds #170183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better matches the code formatter and I personally find the visual indication valuable when I am scrolling/glancing at a comment.
Member
|
@llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesThis better matches the code formatter and I personally find the visual indication valuable when I am scrolling/glancing at a comment. Full diff: https://github.com/llvm/llvm-project/pull/170183.diff 2 Files Affected:
diff --git a/.ci/generate_test_report_lib.py b/.ci/generate_test_report_lib.py
index ce8262f0dc73f..10529c26ec337 100644
--- a/.ci/generate_test_report_lib.py
+++ b/.ci/generate_test_report_lib.py
@@ -184,8 +184,8 @@ def generate_report(
if return_code == 0:
report.extend(
[
- "The build succeeded and no tests ran. This is expected in some "
- "build configurations."
+ ":white_check_mark: The build succeeded and no tests ran. "
+ "This is expected in some build configurations."
]
)
else:
@@ -272,6 +272,8 @@ def plural(num_tests):
]
)
report.extend(_format_failures(ninja_failures, failure_explanations))
+ else:
+ report.extend(["", ":white_check_mark: The build succeeded and all tests passed."])
if failures or return_code != 0:
report.extend(["", UNRELATED_FAILURES_STR])
diff --git a/.ci/generate_test_report_lib_test.py b/.ci/generate_test_report_lib_test.py
index 341cf3037b921..182af1d52641a 100644
--- a/.ci/generate_test_report_lib_test.py
+++ b/.ci/generate_test_report_lib_test.py
@@ -194,7 +194,7 @@ def test_title_only(self):
"""\
# Foo
- The build succeeded and no tests ran. This is expected in some build configurations."""
+ :white_check_mark: The build succeeded and no tests ran. This is expected in some build configurations."""
),
)
@@ -308,7 +308,9 @@ def test_no_failures(self):
"""\
# Foo
- * 1 test passed"""
+ * 1 test passed
+
+ :white_check_mark: The build succeeded and all tests passed."""
)
),
)
|
|
✅ With the latest revision this PR passed the Python code formatter. |
cmtice
approved these changes
Dec 1, 2025
Contributor
cmtice
left a comment
cmtice
left a comment
There was a problem hiding this comment.
Do you plan on any emojis for failed builds/tests? Maybe a red "x"?
Contributor
Author
That's a good idea. I'll put it on the list. We might want to stick to what the code formatting action does for now and use |
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
This better matches the code formatter and I personally find the visual indication valuable when I am scrolling/glancing at a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better matches the code formatter and I personally find the visual indication valuable when I am scrolling/glancing at a comment.